Enable support for macOS 10.12 Sierra

matschaffer / knife-solo

DEPRECATED: Please consider using https://knife-zero.github.io/, ansible, or visit https://www.chef.io/ for other ideas

MIT License

786 stars 213 forks source link

Enable support for macOS 10.12 Sierra #498

Open CGamesPlay opened 7 years ago

CGamesPlay commented 7 years ago

Since SIP landed, /usr/local/bin has been removed from the default paths. You can confirm this with ssh new-sierra-host env, and inspecting the PATH. To fix this, I needed to ensure that /usr/local/bin is added via .bashrc for the non-admin running user.

Additionally, the TMPDIR on macOS is readable only by the user who created the file. In chef's case, this means root. This means that no chef script resource that runs as a user can actually succeed, because the interpreter can't read the script file. I added a line to solo.rb to set the TMPDIR to something world-readable.

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 89.265% when pulling 6ceb47d709065d83fc95436ddccbd72aa90501a7 on CGamesPlay:master into 5e9f6528709d63f1d9eba69d54d6bc76658df2cd on matschaffer:master.

aried3r commented 7 years ago

@CGamesPlay I think the tests that fail have been fixed on the master branch. So I think if you would rebase your branch on the current master branch, your PR should have successful test runs.

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 89.077% when pulling f813f54e42fa6d2c8ed42a0fa03fdd31e18b2292 on CGamesPlay:master into baa77a52a83079b17b6f4d08da927b82b2401def on matschaffer:master.

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 89.095% when pulling fa4487091e0bae26f89bc012295ac8f9b2c88d86 on CGamesPlay:master into bedc1005575f94b4348f651d4bf780d5ebcb46d9 on matschaffer:master.