search

matschaffer / knife-solo

DEPRECATED: Please consider using https://knife-zero.github.io/, ansible, or visit https://www.chef.io/ for other ideas
MIT License
786 stars 213 forks source link

Add local_mode true to knife.rb #501

Closed nachbar closed 7 years ago

nachbar commented 7 years ago

Without the local_mode true setting in knife.rb, the knife-solo_data_bag gem can try to access a Chef Server when showing or editing a data bag, as noted here: https://github.com/thbishop/knife-solo_data_bag/issues/35

As noted there, setting local_mode true fixes the problem, and making it the default when using knife solo init probably makes sense. However, I don't know enough about Chef / Knife workflow to know if adding this option could cause problems for others, especially if they are using both knife solo and Chef server from the same folder.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 89.499% when pulling d558a73911d7dfab20608fb1693059593d74245e on nachbar:add-local-mode-true into 5e9f6528709d63f1d9eba69d54d6bc76658df2cd on matschaffer:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 89.499% when pulling d558a73911d7dfab20608fb1693059593d74245e on nachbar:add-local-mode-true into 5e9f6528709d63f1d9eba69d54d6bc76658df2cd on matschaffer:master.

runningman84 commented 7 years ago

It might make sense to integrate this too: https://github.com/matschaffer/knife-solo/pull/385

matschaffer commented 7 years ago

If nothing else I'm pretty sure it'll still break anyone who's using ruby roles and/or environments. Which I'd guess many are since the main chef docs show ruby before JSON for those items.

Like I mentioned on #385, I'd love to do local mode, but if we release it like this I think we'll get a ton of "the latest release doesn't work" reports from people who've been using chef for awhile.