Support a configuration parameter `solo_legacy_mode` and --legacy-mode option

matschaffer / knife-solo

DEPRECATED: Please consider using https://knife-zero.github.io/, ansible, or visit https://www.chef.io/ for other ideas

MIT License

786 stars 213 forks source link

Support a configuration parameter `solo_legacy_mode` and --legacy-mode option #504

Closed hirose31 closed 7 years ago

hirose31 commented 7 years ago

From Chef 12.10.54 (12.11.18 in officially release version) chef-solo run as local mode by default.

This PR enables to run chef-solo as legacy mode by two ways:

knife solo cook --legacy-mode option
put solo_legacy_mode true into .chef/knife.rb

ref #503

coveralls commented 7 years ago

Coverage increased (+0.003%) to 89.502% when pulling a02134a1cf3c076b9826561de199398a6dfb07b1 on hirose31:solo_legacy_mode into 5e9f6528709d63f1d9eba69d54d6bc76658df2cd on matschaffer:master.

coveralls commented 7 years ago

Coverage decreased (-0.0003%) to 89.499% when pulling 42183452c171e9f88ee5c90bf2ee942a89c5da97 on hirose31:solo_legacy_mode into 5e9f6528709d63f1d9eba69d54d6bc76658df2cd on matschaffer:master.

coveralls commented 7 years ago

hirose31 commented 7 years ago

I hope for releasing next version and available from rubygems.org soon for all of knife solo users ☺️

matschaffer commented 7 years ago

@hirose31 the main thing that tends to hold me up are getting the tests green. I never like to push a release until that happens, but almost every time the outside world drifts enough to start seeing failures (like the current 1.9.3 error with a transient gem).

If you'd like to speed it along, getting that to pass as well as the EC2 integration tests would definitely help.

The steps in https://github.com/matschaffer/knife-solo/blob/master/script/newb should help outline what's required to run the integration suite if you'd like to try it.

I'm happy to also remove old integration test if you find something no longer makes sense (e.g., very old OS version, etc).