search

matschaffer / knife-solo

DEPRECATED: Please consider using https://knife-zero.github.io/, ansible, or visit https://www.chef.io/ for other ideas
MIT License
786 stars 213 forks source link

Resolved some of dependencies which requires ruby >= 2.0 to get the test passing (chef-10, chef-11) #505

Closed hirose31 closed 7 years ago

hirose31 commented 7 years ago

ref #504

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 89.499% when pulling 26a2a4d1b75175801b4e501c186346da061b5c16 on hirose31:resolve-dependencies-chef-10_11 into 797805db69786fd0765d256b380bdc48e57434cc on matschaffer:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 89.499% when pulling 26a2a4d1b75175801b4e501c186346da061b5c16 on hirose31:resolve-dependencies-chef-10_11 into 797805db69786fd0765d256b380bdc48e57434cc on matschaffer:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 89.499% when pulling c7068220d649da6830e549f6ca203590cfd33d66 on hirose31:resolve-dependencies-chef-10_11 into 797805db69786fd0765d256b380bdc48e57434cc on matschaffer:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 89.499% when pulling c7068220d649da6830e549f6ca203590cfd33d66 on hirose31:resolve-dependencies-chef-10_11 into 797805db69786fd0765d256b380bdc48e57434cc on matschaffer:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 89.499% when pulling 0e8ac590b108646ea66cdc30744270663787ee85 on hirose31:resolve-dependencies-chef-10_11 into 797805db69786fd0765d256b380bdc48e57434cc on matschaffer:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 89.499% when pulling 0e8ac590b108646ea66cdc30744270663787ee85 on hirose31:resolve-dependencies-chef-10_11 into 797805db69786fd0765d256b380bdc48e57434cc on matschaffer:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 89.309% when pulling 944162fbe5400da41d9651b20a580ba7f4effb1d on hirose31:resolve-dependencies-chef-10_11 into 797805db69786fd0765d256b380bdc48e57434cc on matschaffer:master.

hirose31 commented 7 years ago

@matschaffer

Could you tell me any advise?

Travis CI say in https://travis-ci.org/matschaffer/knife-solo/jobs/205694137 : 

Bundler could not find compatible versions for gem "json":
  In Gemfile:
    chef (~> 10) ruby depends on
      json (<= 1.6.1, >= 1.4.4) ruby
    json (1.8.1)

But chef 10.34.6 https://rubygems.org/gems/chef/versions/10.34.6 requires json <= 1.8.1, >= 1.4.4. Who requires json (<= 1.6.1, >= 1.4.4)?

matschaffer commented 7 years ago

If you can repro locally the Gemfile.lock should tell you where the constraint is coming from. Not sure offhand though.

Or might be time to just cut a new 0.X and drop chef 10 support. I'd be fine with that.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 89.309% when pulling 0f630b21159148ef063ab73897673dfff25822a9 on hirose31:resolve-dependencies-chef-10_11 into 797805db69786fd0765d256b380bdc48e57434cc on matschaffer:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 89.309% when pulling 0f630b21159148ef063ab73897673dfff25822a9 on hirose31:resolve-dependencies-chef-10_11 into 797805db69786fd0765d256b380bdc48e57434cc on matschaffer:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 89.309% when pulling 0f630b21159148ef063ab73897673dfff25822a9 on hirose31:resolve-dependencies-chef-10_11 into 797805db69786fd0765d256b380bdc48e57434cc on matschaffer:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 89.309% when pulling 0f630b21159148ef063ab73897673dfff25822a9 on hirose31:resolve-dependencies-chef-10_11 into 797805db69786fd0765d256b380bdc48e57434cc on matschaffer:master.

hirose31 commented 7 years ago

@matschaffer

OK, The root cause is the bundler's bug.

does not install latest version of gems dependencies, installs older instead https://github.com/bundler/bundler/issues/3089

This bug was fixed in bundler v1.7.9, but the version of bundler in test environment is 1.7.6.

As a workaround, I've changed the version of chef from ~>10 to ~> 10.34 in Gemfile.chef-10. I think it is no problem because Chef 10.x will not release any more (last release is v10.34.6 in 2014-11-10).

matschaffer commented 7 years ago

Sounds like an optimal fix to me. Thanks for rooting it out!

On Thu, Mar 2, 2017 at 17:43 hirose31 notifications@github.com wrote:

@matschaffer https://github.com/matschaffer

OK, The root cause is the bundler's bug.

does not install latest version of gems dependencies, installs older instead bundler/bundler#3089 https://github.com/bundler/bundler/issues/3089

This bug was fixed in bundler v1.7.9, but the version of bundler in test environment is 1.7.6.

As a workaround, I've changed the version of chef from ~>10 to ~> 10.34 in Gemfile.chef-10. I think it is no problem because Chef 10.x will not release any more (last release is v10.34.6 in 2014-11-10).

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/matschaffer/knife-solo/pull/505#issuecomment-283591913, or mute the thread https://github.com/notifications/unsubscribe-auth/AAACsgctjlAtiWxwWV3oK_M32gyp3Xqhks5rhoEjgaJpZM4MMsjF .

--

-Mat

matschaffer.com