search

matschaffer / knife-solo

DEPRECATED: Please consider using https://knife-zero.github.io/, ansible, or visit https://www.chef.io/ for other ideas
MIT License
786 stars 213 forks source link

Add Ruby 2.3 and 2.4 to Travis #507

Closed aried3r closed 7 years ago

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.02%) to 89.326% when pulling b0d84becea337ea7a9e7a7a3df54a5f96f0fd9eb on ar/travis_ruby_update into baa77a52a83079b17b6f4d08da927b82b2401def on master.

aried3r commented 7 years ago

@matschaffer, what do you think about the failures? https://travis-ci.org/matschaffer/knife-solo/builds/211492644

Since Chef 10 isn't officially supported anymore, I'd add that to the allowed failures with Ruby 2.3 and 2.4. Not sure about Chef 11 and Ruby 2.4 though.

matschaffer commented 7 years ago

@aried3r yeah, adding all those to expected failures seems reasonable to me. Doesn't look like the gemfiles have a committed lock, so it would seem bundler is just landing on an incompatible set of resolved versions.

aried3r commented 7 years ago

I (finally) edited the PR. Now that Chef 13 is out, do you think we can drop support for EOL Rubies and Chefs?

I'd only support Ruby 2.2.x+ and Chef 12+, especially considering that you have very little time to maintain this gem.

On that note, thank you for 0.7.0.pre! I'm using it successfully with Chef 13 :)

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 89.326% when pulling ad3140203368703507cfb424701d3b4b843a7740 on ar/travis_ruby_update into b227f8ad4e90e0d263d212402d2fbfbee4b0e05a on master.

matschaffer commented 7 years ago

Yeah, that does seem to make sense considering https://www.ruby-lang.org/en/news/2016/02/24/support-plan-of-ruby-2-0-0-and-2-1/ - can't find any EOL for chef 11, but like you said, I can't provide much time to support here so maybe better to just focus on the future.

aried3r commented 7 years ago

https://blog.chef.io/2017/03/29/upgrading-chef-client-13/

We always support the last major version of Chef, so currently we support Chef Client 11 and 12. When we release Chef Client 13, Chef Client 11 will be End Of Life, but Chef Client 12 will continue to be supported until Chef Client 14 is released in April 2018.

End Of Life means that we will no longer provide any new releases of Chef Client 11, but Chef Server and Hosted Chef will continue to allow users of Chef Client 11 to synchronise their nodes. For Hosted Chef, we will announce a sunset time for support of Chef Client 11 separately.

I guess this gem is only concerned about chef client, no?

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 89.326% when pulling c321d03a640ca738f556606b5d54601868c991f6 on ar/travis_ruby_update into b227f8ad4e90e0d263d212402d2fbfbee4b0e05a on master.

matschaffer commented 7 years ago

I'd say so. Nice find!

On Thu, Jul 6, 2017 at 19:52 Anton Rieder notifications@github.com wrote:

https://blog.chef.io/2017/03/29/upgrading-chef-client-13/

We always support the last major version of Chef, so currently we support Chef Client 11 and 12. When we release Chef Client 13, Chef Client 11 will be End Of Life, but Chef Client 12 will continue to be supported until Chef Client 14 is released in April 2018.

End Of Life means that we will no longer provide any new releases of Chef Client 11, but Chef Server and Hosted Chef will continue to allow users of Chef Client 11 to synchronise their nodes. For Hosted Chef, we will announce a sunset time for support of Chef Client 11 separately.

I guess this gem is only concerned about chef client, no?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/matschaffer/knife-solo/pull/507#issuecomment-313363467, or mute the thread https://github.com/notifications/unsubscribe-auth/AAACslURd6iJRFMI2sgG1DRu9EHJUuHyks5sLLxtgaJpZM4Mec-l .

--

-Mat

matschaffer.com

aried3r commented 7 years ago

This PR is done and I'd remove Chef 10 and 11 and add 13 in another PR if that's alright with you.

matschaffer commented 7 years ago

Sounds great to me. Thanks @aried3r !