search

matschaffer / knife-solo

DEPRECATED: Please consider using https://knife-zero.github.io/, ansible, or visit https://www.chef.io/ for other ideas
MIT License
786 stars 213 forks source link

Add rvm 2.3.4 for integration chef ~> 13 #509

Closed hirose31 closed 7 years ago

hirose31 commented 7 years ago

Chef ~> 13 requires Ruby version >= 2.3.0, so this PR add rvm 2.3.4.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.02%) to 89.326% when pulling be776e684edfa883a312416eea888413ec755519 on hirose31:fix/travis-master into baa77a52a83079b17b6f4d08da927b82b2401def on matschaffer:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.04%) to 89.272% when pulling 153b7da36edb1178b58f6e466dc76bfeb5401b57 on hirose31:fix/travis-master into baa77a52a83079b17b6f4d08da927b82b2401def on matschaffer:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.02%) to 89.326% when pulling c5bfba11f23e6bad7faa8c10b0f2e834695b0e8c on hirose31:fix/travis-master into baa77a52a83079b17b6f4d08da927b82b2401def on matschaffer:master.

hirose31 commented 7 years ago

@matschaffer /cc @aspyatkin

Head of opscode/chef requires Ruby >= 2.3.0 https://github.com/chef/chef/blob/master/chef.gemspec#L16, so I've added rvm 2.3.4 to .travis.yml.

But still Gemfile.chef-master w/ Ruby 2.3.4 fails. https://travis-ci.org/matschaffer/knife-solo/jobs/218735418

Bundler could not find compatible versions for gem "ohai": In Gemfile: chef was resolved to 13.0.98, which depends on ohai (~> 13.0)

The root cause is that Chef 13.0.98 requires ohai ~> 13.0 but ohai 13 is not released yet! https://github.com/chef/chef/blob/master/Gemfile#L14-L15

any workaround?

matschaffer commented 7 years ago

So long as ohai 13.0 is available in git you should be able to have the Gemfile resolve from there.

On Wed, Apr 5, 2017 at 13:12 hirose31 notifications@github.com wrote:

@matschaffer https://github.com/matschaffer /cc @aspyatkin https://github.com/aspyatkin

Head of opscode/chef requires Ruby >= 2.3.0 https://github.com/chef/chef/blob/master/chef.gemspec#L16, so I've added rvm 2.3.4 to .travis.yml.

But still Gemfile.chef-master w/ Ruby 2.3.4 fails. https://travis-ci.org/matschaffer/knife-solo/jobs/218735418

Bundler could not find compatible versions for gem "ohai": In Gemfile: chef was resolved to 13.0.98, which depends on ohai (~> 13.0)

The root cause is that Chef 13.0.98 requires ohai ~> 13.0 but ohai 13 is not released yet! https://github.com/chef/chef/blob/master/Gemfile#L14-L15

any workaround?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/matschaffer/knife-solo/pull/509#issuecomment-291749173, or mute the thread https://github.com/notifications/unsubscribe-auth/AAACsgzDpcFnnDUJUfSdOqzk-WLk9ZRQks5rsxSvgaJpZM4MztHn .

--

-Mat

matschaffer.com

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.02%) to 89.326% when pulling b2a6b1662dc6359f375f0430f424606d1004156f on hirose31:fix/travis-master into baa77a52a83079b17b6f4d08da927b82b2401def on matschaffer:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.02%) to 89.326% when pulling b2a6b1662dc6359f375f0430f424606d1004156f on hirose31:fix/travis-master into baa77a52a83079b17b6f4d08da927b82b2401def on matschaffer:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.02%) to 89.326% when pulling b2a6b1662dc6359f375f0430f424606d1004156f on hirose31:fix/travis-master into baa77a52a83079b17b6f4d08da927b82b2401def on matschaffer:master.

hirose31 commented 7 years ago

OK, All builds passed!

matschaffer commented 7 years ago

:heart: