Closed aried3r closed 7 years ago
@aried3r normally coveralls would give us some idea I think but looks like the integration is broken. I restarted the PR job to see if maybe it's just something transient.
Ah. Looks like it was the the proxy test, so I commented it out for now.
The initial coverage reports look okay as far as this PR goes. Looks like one unused method (stderr_or_stdout
) and the bootstraps are (understandably) uncovered.
I noticed the freebsd bootstrapper has a 1.9 ruby env var in there, but we should probably verify freebsd boostrapping before changing that.
@aried3r should be all fixed up. Good to merge or do you want to tweak anything?
Looks good! I didn't know about Manifest.txt, what is it used for?
It's used in the gemspec to select which files to upload when the gem is packaged/published.
Many folks use a git list for that but I was never a fan of shelling out during the gem build. Been bitten by it once or twice.
As you can see on https://github.com/matschaffer/knife-solo/blob/master/Rakefile there are also a handful of files I like to keep checked in but don't need to be included with the gem.
On Mon, Jul 10, 2017 at 21:22 Anton Rieder notifications@github.com wrote:
Looks good! I didn't know about Manifest.txt, what is it used for?
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/matschaffer/knife-solo/pull/516#issuecomment-314089522, or mute the thread https://github.com/notifications/unsubscribe-auth/AAACsmxLL2z4ZiMYEkA6xu8jH3WVIvWoks5sMhd7gaJpZM4OSESG .
--
-Mat
matschaffer.com
As discussed in #507.
I am not sure which issues can be closed or which code can be removed now, though.