Closed el-dude closed 7 years ago
The 0.7.0 prerelease should solve this.
For others who run into this:
gem uninstall knife-solo
gem install knife-solo --pre
Thanks @zsellera. It's probably time I just give up on the integration suite and release the pre as 0.7.0 ☹️
Any further plans for the 0.7 release? i just stumbled into this with Chef Development Kit Version: 3.0.36 chef-client version: 14.1.12
Yeah, I'm still pretty conflicted there, but maybe it's time to just pull the trigger and release 0.7.0 from master even though the integration suite is failing. So hard to say since I really haven't used the tool at all in years.
Any opinions there @tmatilai @aried3r @iidatomohiko or @tknerr ?
I've been pointing my Gemfile to 0.7.0.pre3 for the longest time and haven't faced any issues. But I use a very minimal subset of what knife-solo can do probably.
But I understand that releasing with a failing test suite feels weird. But I see a green build here: https://travis-ci.org/matschaffer/knife-solo/branches What exactly is failing?
These ones are failing https://github.com/matschaffer/knife-solo/blob/master/Rakefile#L84 they use EC2 instance to do full integration testing. They do catch problems but mostly they go red just because something else in the ecosystem moved around a bit.
And they are quite old from what I can see, Ubuntu 12.04 is EOL even. Understandably you don't want to release something where not all tests run, but I'd argue quite some work would have to go into that setup to make it work again.
I'm all for a 0.7.0 or even 1.0.0 of knife-solo. I've been using it for quite some time and it's almost always been other moving parts, not knife-solo that broke. :)
Alrighty then :) I'll prep the release
On Mon, Oct 22, 2018 at 20:04 Anton Rieder notifications@github.com wrote:
And they are quite old from what I can see, Ubuntu 12.04 is EOL even. Understandably you don't want to release something where not all tests run, but I'd argue quite some work would have to go into that setup to make it work again.
I'm all for a 0.7.0 or even 1.0.0 of knife-solo. I've been using it for quite some time and it's almost always been other moving parts, not knife-solo that broke. :)
— You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/matschaffer/knife-solo/issues/517#issuecomment-431796481, or mute the thread https://github.com/notifications/unsubscribe-auth/AAACsqH9ucFfcUgv0f3hvANGxw527rs_ks5unaY9gaJpZM4OnPhQ .
--
-Mat
matschaffer.com
https://rubygems.org/gems/knife-solo/versions/0.7.0 is up - tests seem to pass. Hope it works for everyone.