search

matschaffer / knife-solo

DEPRECATED: Please consider using https://knife-zero.github.io/, ansible, or visit https://www.chef.io/ for other ideas
MIT License
786 stars 213 forks source link

Use new supermarket API URL for librarian #533

Closed aried3r closed 6 years ago

aried3r commented 6 years ago

In my case, for some reason the old URL didn't work at all anymore. But I couldn't find any info if it has been turned off.

Anyway, this is the new URL anyway and I've tested locally that this works. :)

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 90.116% when pulling caf4a498118c4a4413db581c4966eef173731737 on ar/librarian_supermarket_url into 3c851a4faee46dd1d0682642632c96e165329c7c on master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 90.116% when pulling caf4a498118c4a4413db581c4966eef173731737 on ar/librarian_supermarket_url into 3c851a4faee46dd1d0682642632c96e165329c7c on master.

matschaffer commented 6 years ago

Hey thanks! Tests seem to pass. Judging from the date of the last librarian-chef commit, I’d say that’s probably good enough 😉

aried3r commented 6 years ago

On an unrelated note, will knife-solo see a 0.7.0 release? I've been using it for the longest time now and found no errors. Given, we probably make use of 5% of the features.

matschaffer commented 6 years ago

Yeah I was talking to folks about that at rubykaigi. Maybe it's time to just release it.

Normally I'd like to have the integration tests working but I'm not sure if I'll have time to get them fixed.

On Sun, Jun 10, 2018 at 23:42 Anton Rieder notifications@github.com wrote:

On an unrelated note, will knife-solo see a 0.7.0 release? I've been using it for the longest time now and found no errors. Given, we probably make use of 5% of the features.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/matschaffer/knife-solo/pull/533#issuecomment-396054405, or mute the thread https://github.com/notifications/unsubscribe-auth/AAACsvICvgmCS2S02jSh7JalyC2skrrSks5t7TBAgaJpZM4Uhuh9 .

--

-Mat

matschaffer.com