search

matschaffer / win32-open3-19

DEPRECATED: Provides Open4.popen4 via win32/open3 (win32-open3 behavior from 1.8) on ruby 1.9. Don't use this for new code.
7 stars 4 forks source link

What's the point? #3

Closed djberg96 closed 12 years ago

djberg96 commented 12 years ago

This code has nothing to do with win32-open3 or Windows as far as I can tell. It runs on any platform with Ruby 1.9.x. The win32-open3 gem already defines an Open4.popen4 method. And there's already a popen4 gem out there, too.

However, by naming it win32-open3-19 you are giving people the impression there's some relationship with win32-open3 when there's none that I can see.

Any chance I could get you to yank the gem and kill this?

Regards,

Dan

matschaffer commented 12 years ago

Hey Dan,

This gem was to get windows ruby1.9 compatibility in another gem (I think chef) that expected to get Open4.popen4 by requiring 'win32/open3' without forking the original gem.

Yanking it would take work to verify that nothing is actually using it, but I'll update the descriptions to say that it's deprecated.

-Mat

On Apr 7, 2012, at 1:21 AM, Daniel Berger reply@reply.github.com wrote:

This code has nothing to do with win32-open3 or Windows as far as I can tell. It runs on any platform with Ruby 1.9.x. The win32-open3 gem already defines an Open4.popen4 method. And there's already a popen4 gem out there, too.

However, by naming it win32-open3-19 you are giving people the impression there's some relationship with win32-open3 when there's none that I can see.

Any chance I could get you to yank the gem and kill this?

Regards,

Dan

Reply to this email directly or view it on GitHub: https://github.com/matschaffer/win32-open3-19/issues/3

matschaffer commented 12 years ago

Updated descriptions to reflect intent and their deprecated status.

djberg96 commented 12 years ago

Thanks for the clarification. Hope I didn't come off too harsh there.

matschaffer commented 12 years ago

I sensed a little anger, but hitting funky gems late at night can do that. No harm done.

-Mat

On Apr 7, 2012, at 12:16 PM, Daniel Berger reply@reply.github.com wrote:

Thanks for the clarification. Hope I didn't come off too harsh there.

Reply to this email directly or view it on GitHub: https://github.com/matschaffer/win32-open3-19/issues/3#issuecomment-5009704