matsen / pplacer

Phylogenetic placement and downstream analysis
http://matsen.fredhutch.org/pplacer/
GNU General Public License v3.0
75 stars 18 forks source link

Guppy merge 's tree comparison #296

Closed gjospin closed 11 years ago

gjospin commented 11 years ago

Does Guppy's merge command use the tree topology or the tree string to identify if the trees are the same or some of other method?

I just ran into a problem merging trees where my tree strings were different but the topology should have been identical and it gave me an error.

If I were to replace all the trees with 1 version of the tree (for the files I want to merge), and run guppy merge. Would the coordinates not longer be appropriate for the tree that got swapped in?

Thank you

cmccoy commented 11 years ago

In what way(s) do the strings differ?

If I recall correctly, the trees are compared in a rooted sense. Even if you have the same unrooted topology, different rootings between your files will yield different edge numbers, so just changing the newick string in a .jplace file will change the placement locations.

On Fri, Jan 25, 2013 at 2:50 PM, Guillaume Jospin notifications@github.comwrote:

Does Guppy's merge command use the tree topology or the tree string to identify if the trees are the same or some of other method?

I just ran into a problem merging trees where my tree strings were different but the topology should have been identical and it gave me an error.

If I were to replace all the trees with 1 version of the tree (for the files I want to merge), and run guppy merge. Would the coordinates not longer be appropriate for the tree that got swapped in?

Thank you

— Reply to this email directly or view it on GitHubhttps://github.com/matsen/pplacer/issues/296.