search

matsengrp / cft

Clonal family tree
5 stars 3 forks source link

Replace fake build info footer with actual build information #71

Closed metasoarous closed 7 years ago

metasoarous commented 7 years ago

Best way to do this is probably to write out this information from the scons process into the output metadata.json file. However, currently this file is a single array of objects, and needs to be rewritten to be a top level object which has as an attribute the clusters array; There were other things for which we've figured this switch would be useful as well.

metasoarous commented 7 years ago

So... there's some question here about what we should be doing here. Though I've never used it in such a manner, it's supposed to be possible to have the cftweb server load up multiple json files from a single directory. Each of these would likely have it's own (distinct) build information, and so it's not clear what we should be showing in that case. Just pick one and not worry about it? Are we really likely to need to use the ability to load up multiple json files? Maybe that ability should just be taken out? Or should we just forget about build information all together? This certainly isn't core value stuff, but I think it would be nice for users to quickly see when the data was last built maybe even the commit hash (w/ GH link) on which it was built.

matsen commented 7 years ago

I don't see the use case for multiple JSON files. Suggest just having one.

(And agree that there are more important things to worry about!)