search

matsengrp / gctree

GCtree: phylogenetic inference of genotype-collapsed trees
https://matsengrp.github.io/gctree
GNU General Public License v3.0
16 stars 2 forks source link

tree rendering hangs when write directory doesn't exist. #131

Closed jgallowa07 closed 2 weeks ago

jgallowa07 commented 1 month ago

I'm not sure this is the case everywhere, but in my notebook, when I run the tree.render command, and feed it a path that doesn't exist, rather than throwing an error it just spins and kills my kernal. This took a while to figure out so I'd suggest an assert or raise somewhere here maybe

willdumm commented 1 month ago

Thanks for this Jared, sorry it caused you trouble! I will be sure to fix this when I get back.