matsengrp / historydag

https://matsengrp.github.io/historydag
GNU General Public License v3.0
0 stars 1 forks source link

Implement Sum RF Distances #41

Closed clarisw closed 1 year ago

willdumm commented 1 year ago

This is looking great, Claris! The test still isn't passing, but I rewrote it a bit to make it more clear what's supposed to happen, and I fixed a couple of minor things.

I'm not quite sure what's going on here, but it's possible that either some math is incorrect (for example in the issue #39 ), or there's something wrong with count_nodes, etc.

A couple of comments:

willdumm commented 1 year ago

^^ I figured out where the math was wrong, and pushed the changes needed to make the test run.

Here's a list of to-do's, just so we can keep track (I know we've talked about some of these already):

willdumm commented 1 year ago

This looks great, Claris! Feel free to merge it whenever you're ready.

willdumm commented 1 year ago

^ I just rebased, to make things easier!