matsengrp / historydag

https://matsengrp.github.io/historydag
GNU General Public License v3.0
0 stars 1 forks source link

Jukes cantor likelihood #73

Closed willdumm closed 1 year ago

willdumm commented 1 year ago

This PR provides an implementation of Jukes Cantor likelihood on histories, with branch lengths inferred to match the expected number of mutations on each branch to the observed number of mutations on that branch.

Also included:

matsen commented 1 year ago

but those plans have been scrapped

Can you remind me-- this is because it just didn't work well?

willdumm commented 1 year ago

For now I've abandoned the idea because there doesn't seem to be a good way of counting bifurcating resolutions correctly, since the new nodes that would result from resolving a multifurcating node may already be in the DAG. I think there's something more involved that could be done that would involve changing the data structure slightly...