matsengrp / olmsted

B-cell repertoire and clonal family tree explorer
http://olmstedviz.org
GNU Affero General Public License v3.0
15 stars 4 forks source link

Consider selection from a single pane #91

Open metasoarous opened 6 years ago

metasoarous commented 6 years ago

For now in #34, I think we're going to be doing selections along the lines of this vega spec, where selections while under facet will select across all panes of the facet. This seems fine to me for now, and may actually be the behavior people want by default. But it may be worth exploring whether it's possible to arrange things so that table selections are restricted to the pane you select from, based on mouse up/down events.

eharkins commented 6 years ago

@metasoarous the brush_store and brush signals in this and other brush examples just store the information regarding the interval of values brushed in that group. So if we wanted to filter our selection results by the categorical value of the subplot such as has_seed:true, we'd just need to store that information with the brush selection in the redux state for the selector to do the filtering. In the case of #90, since we'd have different ranges for different subplots, we'd of course use the ranges and corresponding fields from the plot we selected in, which might include points from other plots that happen to fall in that range, as opposed to in #34 where no point is in multiple subplots.