search

matsengrp / torchdms

Analyze deep mutational scanning data with PyTorch
https://matsengrp.github.io/torchdms/
2 stars 0 forks source link

Probable plotting bug #172

Closed wsdewitt closed 2 years ago

wsdewitt commented 2 years ago

The boolean indexing in these lines is a self comparison, so either it's not needed, or it was intending to do something else: https://github.com/matsengrp/torchdms/blob/7003697b61ec4cf759baf9b235c1dc4a353b4b86/torchdms/plot.py#L87-L88

jgallowa07 commented 2 years ago

This is for removing nulls I believe? otherwise the pearson correlation coeff function get's angry

wsdewitt commented 2 years ago

I see, so do we want ~targ.isnan() or targ.isfinite()?

wsdewitt commented 2 years ago

Just noticed you fixed in #171, thanks!