search

matsim-scenarios / matsim-germany

GNU General Public License v2.0
0 stars 5 forks source link

sort out path to svn directories #2

Open GregorRyb opened 1 year ago

GregorRyb commented 1 year ago

the run script should point to something like ../../shared-svn See: https://wiki.vsp.tu-berlin.de/node/165 --> VSP convention

Janekdererste commented 1 year ago

I think the ../../shared-svn thing is a stupid convention. How do you know where people put their repos and projects. \

You could instad require path/to/shared-svn as a command line parameter and then have relative paths like projects/germany.... in your code

kainagel commented 1 year ago

Well if you see this then you make a symbolic link to that location. It is not that difficult.

If people prefer an explicit command line parameter, then so be it. We currently have two different ways to deal with command line params (the Sebastian Hörl way and the Christian Rakow way); it would need to be documented; and it means a run config for every (such) class that I run. If the majority thinks that this is an advantage, then I will live with it.

Janekdererste commented 1 year ago

I never use sym links 😬. I guess it doesn't matter anyway, as the shared-svn is used for internal data and everybody with access knows how to alter a run script.

One can also have a command line parameter for the repository root and let it default to ../../share-svn. This way it is one place to change in the run script in case someone (like me) doesn't know how sym links while it works by default for those who adhere to that folder structure.

The actual paths would then be built like var networkPath = sharedSvnRoot.resolve("/path/to/project/network.xml.gz")