matsim-vsp / parallel_qsim_rust

Parallel and distributed implementation of the Qsim in Rust
8 stars 0 forks source link

Re-introduce unit tests for simulation #114

Closed Janekdererste closed 8 months ago

Janekdererste commented 9 months ago

Because I didn't know how to resolve that immediately, I decided to take out unit tests in simulation.rs think about how to re-introduce those tests.

Also, I would prefer only one variant of execute_qsim. As far as I am concerned, we can also execute the single partition Qsim in another thread. This test is there to make sure that the overall simulation logic, without messaging, works correctly.

Janekdererste commented 8 months ago

This was done in commit https://github.com/Janekdererste/rust_q_sim/commit/96aeaa574aeff7e421b87f7297264f8d0444b1b4

paulheinr commented 8 months ago

Is it? Tests are still commented out.