matsim-vsp / parallel_qsim_rust

Parallel and distributed implementation of the Qsim in Rust
8 stars 0 forks source link

Confusing file names network_partition.rs and partitioned_network.rs #52

Closed paulheinr closed 1 year ago

paulheinr commented 1 year ago

Both files are called very similar.

network_partition.rs consists of the NetworkPartition struct itself. partitioned_network.rs consists of the Network struct. I suggest that either both files should have more different names or they should be merged into one file

Janekdererste commented 1 year ago

Yes, good point. I think initially ther was a network and then I introduced partitioned_network and then the file became large, so I refactored network_partition into its own file.

paulheinr commented 1 year ago

I see. What about renaming partitioned_network to network? Small downside is that the module, where all these files are placed, is also called network.

Janekdererste commented 1 year ago

Do it!