search

matsim-vsp / pave

https://matsim-vsp.github.io/pave
GNU General Public License v2.0
2 stars 2 forks source link

NullPointerException #17

Open michalmac opened 4 years ago

michalmac commented 4 years ago

https://travis-ci.org/github/matsim-vsp/pave/builds/706065889

Seems that serviceTask may be null: https://github.com/matsim-vsp/pave/blob/545e978781543754f19f3549b6ee45352f42c943/src/main/java/org/matsim/pfav/privateAV/FreightTourDispatchAnalyzer.java#L127

michalmac commented 4 years ago

Same here: https://travis-ci.org/github/matsim-vsp/pave/builds/706069530 (different test, same error)

tschlenther commented 4 years ago

The tests run through on my machine - build #231 was successfull after a restart, too. When trying to reconstruct the NullPointer, i really was wondering why the error came up with an ActivityEndEvent and not with an ActivityStartEvent.

serviceTask may be null, if no PFAVServiceTask within the tour with status = PERFORMED or status = STARTED can be found. Normally, whenever the corresponding activity is ending, the status of the Task should have one of the aforementioned statuses.

As i could not find a logical reason for that, at the moment, i replaced the NullPointer with an IllegalStateException that gives a somewhat more expressive error message... I will keep an eye on this, but really do not know how to solve it or why it came up in the first place. I should restructure most of the package anyway eventually..