search

matsluni / aws-spi-akka-http

This is an alternative implementation of the new aws java sdk v2 non-blocking async SPI. It provides an alternative to the built-in Netty implementation based on akka-http.
Apache License 2.0
33 stars 15 forks source link

Allow using SdkHttpConfigurationOption over default akka-http connection settings #255

Open jtjeferreira opened 2 months ago

jtjeferreira commented 2 months ago

introduce withConnectionPoolSettingsBuilder and withConnectionPoolSettingsBuilderFromAttributeMap to allow the usage of AWS SDK configuration options

This change is introduced in a backwards compatible change. To use the new functionality withConnectionPoolSettingsBuilderFromAttributeMap should be used. Check the unit tests for examples

Fixes #232

pjfanning commented 2 months ago

@jtjeferreira when you get this working, would you mind also doing a PR for https://github.com/apache/pekko-connectors which has a Pekko version of this code (in a module)?

jtjeferreira commented 2 months ago

@jtjeferreira when you get this working, would you mind also doing a PR for apache/pekko-connectors which has a Pekko version of this code (in a module)?

For sure. I thought the pekko fork was in https://github.com/pjfanning/aws-spi-pekko-http/ ...

pjfanning commented 2 months ago

@jtjeferreira when you get this working, would you mind also doing a PR for apache/pekko-connectors which has a Pekko version of this code (in a module)?

For sure. I thought the pekko fork was in https://github.com/pjfanning/aws-spi-pekko-http/ ...

We've brought it into Apache Pekko Connectors 1.1. I will maintain https://github.com/pjfanning/aws-spi-pekko-http/ for bug fixes because Apache Pekko Connectors 1.0 still use it but there is probably not much point adding enhancements to my fork. In theory, the Apache Pekko Connectors 1.1 copy of this lib should work with Pekko Connectors 1.0 anyway.