Minor bugfixes, added some nice functions.

matsn0w / MISS-ELS

Server-sided ELS for FiveM with custom patterns per vehicle, custom sirens, indicator control and more!

https://matsn0w.github.io/MISS-ELS

17 stars 13 forks source link

Minor bugfixes, added some nice functions. #177

Closed Druganov1 closed 10 months ago

Druganov1 commented 11 months ago

I fixed the issue/bug where players can still hear the stop sign beeping, even after exiting the vehicle
I tweaked the AddVehicleToTable a little bit, so every extra/misc gets turned off on vehicle spawn, otherwise people need to turn on every light manually and then it would be "resetted". Dont know why this was not added before.
Added light britghtness that can be configured in the config file (For defualt values) and players can also change it in game with the following commands:

/elsdaybrightness [Sets the light brightness during day time]
/elsnightbrightness [Sets the light brightness during night time]

The commands change the brightness live, so no need to reconnect.

matsn0w commented 11 months ago

Hi, first of all: thanks for opening this PR!

Given the fact that we are currently re-writing the entire resource (for OneSync support), it is not very practical to merge all these achanges right now. I am going to leave your PR open so we can implement it when we are done.

Regarding the new environment lighting feature: can you provide some screenshots and/or recordings of it's functionality?

Thanks!

matsn0w commented 11 months ago

PS: actually, maybe you can move the new feature to a separate PR. We might then be able to merge the fixes earlier.

Druganov1 commented 11 months ago

Hi, first of all: thanks for opening this PR!

Given the fact that we are currently re-writing the entire resource (for OneSync support), it is not very practical to merge all these achanges right now. I am going to leave your PR open so we can implement it when we are done.

Regarding the new environment lighting feature: can you provide some screenshots and/or recordings of it's functionality?

Thanks!

we are currently re-writing the entire resource (for OneSync support)

Hmm that sounds nice, is there an ETA on this when this will be finished? And do you guys need help? Im happy to help!

matsn0w commented 11 months ago

Hmm that sounds nice, is there an ETA on this when this will be finished? And do you guys need help? Im happy to help!

Awesome! Help is always very welcome :) We cannot give an ETA because me and @JustinRijsdijk are busy men, but we are aiming for the next month.

Come and visit my Discord, and have a chat with us: https://matsn0w.dev/discord