search

matsui528 / nanopq

Pure python implementation of product quantization for nearest neighbor search
MIT License
323 stars 43 forks source link

Turn print statements into logging #27

Open stephantul opened 1 year ago

stephantul commented 1 year ago

Hi!

Thanks for writing this package, it looks great!

I'd be interested in turning the print statements (with verbose=True) into logging statements. The verbose flag could then be used to control whether this logging is output to stdout (i.e., by setting the log level). Is this something you are interested in? if so, I could submit a PR.

matsui528 commented 1 year ago

Thanks! Just wait a bit, I need to take a look at this PR first #24 (I haven't had time to work on this PR for a long time, though...)

Once that is done, please make a PR! As I'd like to keep this repository as simple as possible, very simple logging is appreciated :)

stephantul commented 1 year ago

Thanks for the response, I'll wait! If you want, you can ping me when this can be started.

matsui528 commented 1 year ago

@stephantul Sorry for the super long delay... Now you can start :+1:

DivyanshVinayak23 commented 4 months ago

If this is still open can I work on this?

stephantul commented 4 months ago

@DivyanshVinayak23 Sure, I totally forgot to pick this up. (@matsui528 my apologies 🙏 )

matsui528 commented 4 months ago

@DivyanshVinayak23 @stephantul Thanks! Please go ahead :+1: