search

matsui54 / ddc-nvim-lsp-doc

Shows completion documentation and signature help from nvim-lsp.
MIT License
21 stars 2 forks source link

`nvim_win_close()` crash #3

Closed Shougo closed 3 years ago

Shougo commented 3 years ago

スクリーンショット_2021-09-05_17-15-28

Shougo commented 3 years ago

It should check winnr('$') value. And it should use winid instead of current widow. Current window may be changed.

matsui54 commented 3 years ago

Thanks for reporting. The invalid id 0 in the error message is not window number but error value of nvim_open_win(). So this is a problem of opening windows.

For workaround, I will add error check of nvim_open_win().

Shougo commented 3 years ago

Oh, OK.

matsui54 commented 3 years ago

Can you update and check it?

Shougo commented 3 years ago

Thanks. I will update it.

Shougo commented 3 years ago

It seems fixed.

matsui54 commented 3 years ago

That's good! Thanks for checking.