matsune / MidiParser

Read/Write SMF(Standard Midi Files) in Swift for iOS/macOS
MIT License
84 stars 36 forks source link

<Belfast> Add Ticks #3

Closed NBelfast closed 4 years ago

NBelfast commented 5 years ago
  1. bug fix: 1.1. incorrect note.timeStamp in case BPM (Beats Per Minute) is not equal to 60 1.2 incorrect unit tests
  2. add refactoring: 2.1. remove redundancy in property names 2.2. move "magic data" to constants and enums 2.3. reorganize code
  3. add new feature: 3.1. add ticks
  4. unit tests: 4.1 add new unit tests

Comments:

NBelfast commented 5 years ago

Hello, Please verify changes. You can reach me in the Telegram in case any further discussion required. My contact in Telegram is Belfast. Thank you.

matsune commented 4 years ago

Sorry for my too late response… Thank you for your contribution.