search

matsuyoshi30 / harbor

Simple and minimal personal blog theme.
MIT License
186 stars 68 forks source link

Can't switch to light mode #48

Closed Jaisu-1 closed 4 years ago

Jaisu-1 commented 4 years ago

I can't seem to switch to light mode in my settings. Are the light mode and dark mode versions two different projects?

Jaisu-1 commented 4 years ago

For information, I am currently running on Ubuntu , maybe detecting system preference from Ubuntu is broken and is hence unable to switch to Light mode. Please look into this, I love this theme and would like to use it :/

hirokisakabe commented 4 years ago

The workaround: You can disable dark mode theme in head.html

- <link id="dark-mode-theme" rel="stylesheet" href="{{ .Site.BaseURL }}css/dark.css" />
+ <link disabled id="dark-mode-theme" rel="stylesheet" href="{{ .Site.BaseURL }}css/dark.css" />
Jaisu-1 commented 4 years ago

Is there no way to be able to toggle between the 2 themes?

On Sun, Aug 30, 2020, 10:04 AM HirokiSAKABE notifications@github.com wrote:

The workaround: You can disable dark mode theme in head.html https://github.com/matsuyoshi30/harbor/blob/master/layouts/partials/head.html

  • +

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/matsuyoshi30/harbor/issues/48#issuecomment-683431296, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJYPGB6VKYJI7V2AAQ67HLTSDJS6ZANCNFSM4QNZ7K2Q .

matsuyoshi30 commented 4 years ago

@Jaisu-1 Thanks reporting this. @HirokiSAKABE solved this problem by #49, so you can toggle between light and dark mode after updating the theme.

@HirokiSAKABE Thank you for great PR!