search

matsuyoshi30 / harbor

Simple and minimal personal blog theme.
MIT License
186 stars 68 forks source link

added Instagram integration #52

Closed Lunarequest closed 4 years ago

Lunarequest commented 4 years ago

I made this quick and simple integration for Instagram. it should be as simple as copy pasting this with some minor changes to link to another social media. This section needs to be added to the config.toml

[params.social.instagram]
    name= "instagram"
    url="link to your account"
    icon="fab fa-instagram fa-2x"

There should be a better way of linking this. like iterating over a bunch of social media configs and linking them with this html.

<a href="{{ $social.url}}" name="$social.name"><i
            class="{{$social.icon}}"></i></a>

but I couldn't really figure out the stuff i needed to do on the config.toml end of things. This is in reference to issue #27

matsuyoshi30 commented 4 years ago

@advaithm Thank you for PR! I reviewed and commented, so please check it.

Lunarequest commented 4 years ago

I will make the changes that you have recommended.

Lunarequest commented 4 years ago

@matsuyoshi30 I have made the changes you recommend please look into this

matsuyoshi30 commented 4 years ago

@advaithm LGTM. Thanks!