matt-daneshvar / laravel-survey

Create and manage surveys within your Laravel app.
MIT License
250 stars 50 forks source link

Translatable #39

Closed scottgrayson closed 1 year ago

scottgrayson commented 2 years ago
matt-daneshvar commented 2 years ago

Hi @scottgrayson and @andreia, thank you for using laravel-survey and for taking the time to create this PR.

I think both spatie/eloquent-sortable and spatie/laravel-translatable are great choices you made in your work, but I'm cautious about adding them as new dependencies to this package, mostly because:

These make me think that it'd be better to leave it to users to install spatie/laravel-translatable directly in their app and extend laravel-survey models and override them as and when they need to.

Leaving the PR open for discussion.