search

matt-hayward / olcPGEX_AnimatedSprite

Easily use animated sprites in the OLC Pixel Game Engine
22 stars 4 forks source link

Added frame duration per state & fixed flipping #2

Closed 0xnicholasc closed 4 years ago

0xnicholasc commented 4 years ago

First time contributing to another project. Hope you find this useful.

0xnicholasc commented 4 years ago

Previous flipping logic only worked when Scale = 1. If scale was >1, Sprite is moved when flipped.

matt-hayward commented 4 years ago

Hey, thanks for contributing! Yeah, this looks useful and was something I was thinking about.

I've added some feedback for you, so let me know if you have any questions.

For the flip issue, I tested on 2x scale and it seemed to work fine. Perhaps the actual image you're using isn't quite centered on the canvas?

If possible, could you also create an issue for the two things fixed here?

0xnicholasc commented 4 years ago

Thanks for the feedback, I'll fix those things you mentioned tomorrow!

On Wed, Jan 29, 2020, 11:13 PM matt-hayward notifications@github.com wrote:

Hey, thanks for contributing! Yeah, this looks useful and was something I was thinking about.

I've added some feedback for you, so let me know if you have any questions.

For the flip issue, I tested on 2x scale and it seemed to work fine. Perhaps the actual image you're using isn't quite centered on the canvas?

If possible, could you also create an issue for the two things fixed here?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/matt-hayward/olcPGEX_AnimatedSprite/pull/2?email_source=notifications&email_token=AONHSGXKS233HBGHD2BQ5ZDRAJHXPA5CNFSM4KNOR6NKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKJT4DI#issuecomment-580075021, or unsubscribe https://github.com/notifications/unsubscribe-auth/AONHSGT3XRSDS4HF6KKJBRTRAJHXPANCNFSM4KNOR6NA .

matt-hayward commented 4 years ago

I've added one final bit of feedback, then I think everything is fine with this PR. Could you create an issue for this, though, please?

0xnicholasc commented 4 years ago

I've added one final bit of feedback, then I think everything is fine with this PR. Could you create an issue for this, though, please?

Incorporating your feedback right now. Did you want me to create an issue on the olcPixelGameEngine?

matt-hayward commented 4 years ago

I've added one final bit of feedback, then I think everything is fine with this PR. Could you create an issue for this, though, please?

Incorporating your feedback right now. Did you want me to create an issue on the olcPixelGameEngine?

No, create an issue on this repo, please.

0xnicholasc commented 4 years ago

I did yesterday.

On Sat, Feb 1, 2020, 9:22 AM matt-hayward notifications@github.com wrote:

I've added one final bit of feedback, then I think everything is fine with this PR. Could you create an issue for this, though, please?

Incorporating your feedback right now. Did you want me to create an issue on the olcPixelGameEngine?

No, create an issue on this repo, please.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/matt-hayward/olcPGEX_AnimatedSprite/pull/2?email_source=notifications&email_token=AONHSGSVHD5LZZEZFIE2GS3RAWASXA5CNFSM4KNOR6NKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKQ6GOI#issuecomment-581034809, or unsubscribe https://github.com/notifications/unsubscribe-auth/AONHSGWQNFFGSPBGXSCCZ4LRAWASXANCNFSM4KNOR6NA .

matt-hayward commented 4 years ago

I've created two separate issues for this PR:

https://github.com/matt-hayward/olcPGEX_AnimatedSprite/issues/4

https://github.com/matt-hayward/olcPGEX_AnimatedSprite/issues/5