matt-j-m / grav-plugin-aura

The Aura Plugin for Grav CMS adds meta tags and structured data to your pages for visually appealing and informative search results and social media shared links.
MIT License
26 stars 7 forks source link

og:url should be based off the site url setting instead of the url in the browser #18

Open jstebenne opened 3 years ago

jstebenne commented 3 years ago

Here is our current setup:

We do local development and pages update, and we access the website with localhost as the address. The admin UI is only installed in our local environment and is not included in the dockerfile of our production environment. So it is not possible to login and edit anything through the internet.

The problem:

With a setup like that, there is no way to generate metadata from the real URL. I would have thought that the URL field in the plugin settings would be used to build og:url but it still writes localhost.

Suggested change:

Use the URL field in the plugin's settings as the base for anything related to the URL. The field is already mandatory so I don't think there should be an impact anywhere.

Karmalakas commented 3 years ago

Not sure this would work for multi-language sites. Especially if different languages are on different subdomains or even domains.