matt-kempster / m2c

A MIPS and PowerPC decompiler.
GNU General Public License v3.0
386 stars 46 forks source link

Split out expressions/evaluators from translate.py #229

Closed zbanks closed 2 years ago

zbanks commented 2 years ago

This PR has two parts:

Overall, I know this is a big PR, but it splits translate.py up into 3 files (each >1k lines) which I think should help with maintenance?

simonlindholm commented 2 years ago

Sorry to be slow to get to this (and to totally bit rot it with by phi refactoring...) I think I like the first part, it feels like a relatively clean conceptual split. The second I'm a bit more torn about; it's probably good but I need to digest it first... I'm a bit cautious about the split given my vim grep-based workflow, but I think I'll manage. (And I'm not planning similarly invasive changes as my phi work any time soon.)

zbanks commented 2 years ago

I'm going to close this PR then, to preserve a record of the two parts if we want to revisit this later. The first part I re-did & moved to #237 .