matt-lourens / hierarqcal

Generate hierarchical quantum circuits for Neural Architecture Search.
https://matt-lourens.github.io/hierarqcal/
BSD 3-Clause "New" or "Revised" License
41 stars 15 forks source link

Sorting Networks with HierarQcal #55

Closed Gopal-Dahale closed 4 weeks ago

Gopal-Dahale commented 1 month ago

Purpose

Tutorial on using HierarQcal for Sorting Networks.

Details

matt-lourens commented 1 month ago

Hey @Gopal-Dahale, this is really great.

It's clear and really uses hierarQcal functionality in a very cool way. I made some comments on the notebook, but it's nothing major, after those small changes #50 will be resolved.

I really liked your use of cycle of cycles in the bitonic sort, the tutorial overall gave me some ideas for hierarQcal improvements. I want to make having a sum of the same motif with only one hyperparamater changing easier (a generalization of the current + functionality).

Anyways thanks for the good work.

Gopal-Dahale commented 1 month ago

I made some comments on the notebook.

Are you yet to make the comments as they are not visible to me?

matt-lourens commented 1 month ago

I made some comments on the notebook.

Are you yet to make the comments as they are not visible to me?

I made them with the review functionality, maybe that doesn't work the way I was expecting, I'll copy them here below:

Comments

Minor stuff:

Gopal-Dahale commented 4 weeks ago

@matt-lourens Can you review the changes?

matt-lourens commented 4 weeks ago

Hey @Gopal-Dahale, yeah it's perfect thanks!