Closed Gopal-Dahale closed 4 weeks ago
Hey @Gopal-Dahale, this is really great.
It's clear and really uses hierarQcal functionality in a very cool way. I made some comments on the notebook, but it's nothing major, after those small changes #50 will be resolved.
I really liked your use of cycle of cycles in the bitonic sort, the tutorial overall gave me some ideas for hierarQcal improvements. I want to make having a sum of the same motif with only one hyperparamater changing easier (a generalization of the current + functionality).
Anyways thanks for the good work.
I made some comments on the notebook.
Are you yet to make the comments as they are not visible to me?
I made some comments on the notebook.
Are you yet to make the comments as they are not visible to me?
I made them with the review functionality, maybe that doesn't work the way I was expecting, I'll copy them here below:
def create_bitonic_sequence
on the 4th line should it not be seq+=
for the d_comparator cycle? currently the first layer does only +BM[2],+BM[2],..., should it not do +BM[2],-BM[2],+BM[2],-BM[2],....?Minor stuff:
i
it with the elements in the sorted part of the array." just remove the hanging "it"@matt-lourens Can you review the changes?
Hey @Gopal-Dahale, yeah it's perfect thanks!
Purpose
Tutorial on using HierarQcal for Sorting Networks.
Details
Qcycle
primitive for Bitonic sort.Mentions
@matt-lourens