search

matt-oakes / dokku-secure-apps

A plugin for Dokku which secures an individual app with HTTP Basic authentication
MIT License
50 stars 7 forks source link

optionally pull username and password from procfile (or some other file)? #2

Closed airtonix closed 9 years ago

airtonix commented 9 years ago

thoughts on this?

matt-oakes commented 9 years ago

I've not tested this, but you might be able to get it working by committing the HTPASSWD file to your repo. What are your reasons for wanting to have the file in your repository? It seems to violate the 3rd of the 12 factors

airtonix commented 9 years ago

Mmm, you're right there... However

I guess I'm really trying to put control of auth details into the Dev who deploys rather than the sysadmin who sets up the dokku server.

I see these as separate roles and allowing the Dev to control who can access their app seems to be reasonable.

On 21 Jan 2015 12:27 am, "Matt Oakes" notifications@github.com wrote:

I've not tested this, but you might be able to get it working by committing the HTPASSWD file to your repo. What are your reasons for wanting to have the file in your repository? It seems to violate the 3rd of the 12 factors

— Reply to this email directly or view it on GitHub.

airtonix commented 9 years ago

Perhaps this is something best handled out of band through something like a modified version of quais. On 21 Jan 2015 12:38 am, "airtonix" airtonix@gmail.com wrote:

Mmm, you're right there... However

I guess I'm really trying to put control of auth details into the Dev who deploys rather than the sysadmin who sets up the dokku server.

I see these as separate roles and allowing the Dev to control who can access their app seems to be reasonable.

On 21 Jan 2015 12:27 am, "Matt Oakes" notifications@github.com wrote:

I've not tested this, but you might be able to get it working by committing the HTPASSWD file to your repo. What are your reasons for wanting to have the file in your repository? It seems to violate the 3rd of the 12 factors

— Reply to this email directly or view it on GitHub.

matt-oakes commented 9 years ago

For now I'm going to close this. Feel free to reopen if you think there's something we need to do.