Implement multiple users

matt-oakes / dokku-secure-apps

A plugin for Dokku which secures an individual app with HTTP Basic authentication

MIT License

50 stars 7 forks source link

Implement multiple users #3

Closed 3onyc closed 9 years ago

3onyc commented 9 years ago

Implemented in this branch:

Multiple users (Add/update/delete/list)
Disable/enable password protection without removing the htpasswd file
Unit tests for new functionality
Unit tests now return non-zero exit code if one or more failed
Fixed running unit tests on Travis

matt-oakes commented 9 years ago

Nice solution! I have a small problem with the naming of some of the commands, but not a big change. I'm also yet to test this out on my dokku instance and I'll likely do that once the commands are renamed.

Thanks for the contribution!

matt-oakes commented 9 years ago

Had a play with it now and it looks really good. There are a few minor problems:

I think we should remove the user namespace for now
I think we should keep the unset name instead of changing it to delete
The unset method is currently missing the path to the HTPASSWD file
The README needs to be updated with the new commands and the first TODO item removed

Thanks for this contribution! It's great!

3onyc commented 9 years ago

Once I get back home I'll implement the changes and fixes, thanks for the feedback!

3onyc commented 9 years ago

All done!

Please let me know if I missed anything or if you spot anything else.

matt-oakes commented 9 years ago

Looks great! Merging it in now.

Thanks again for the contribution!