matt-richardson / gocd-websocket-notifier

GoCD plugin to publish build notifications via websockets to any listener
11 stars 7 forks source link

Exception #1

Closed euven closed 8 years ago

euven commented 8 years ago

Hi Matt,

I installed your plugin as per your configuration instructions on go-server 15.2, but I'm seeing the following exception in my logs:

2015-11-27 10:22:38,000  WARN [63@MessageListener for PluginNotificationListener] PluginNotificationService:78 - Notification update failed for plugin: gocd.websocket.notifier
java.lang.RuntimeException: Interaction with plugin with id 'gocd.websocket.notifier' implementing 'notification' extension failed while requesting for 'stage-status'. Reason: [Unsuccessful response from plugin. 
Plugin returned with code '500' and the following response: '{"status":"failure","messages":[null]}']
        at com.thoughtworks.go.plugin.access.PluginRequestHelper.submitRequest(PluginRequestHelper.java:38)
        at com.thoughtworks.go.plugin.access.notification.NotificationExtension.notify(NotificationExtension.java:74)
        at com.thoughtworks.go.server.messaging.plugin.PluginNotificationService.notifyPlugin(PluginNotificationService.java:61)
        at com.thoughtworks.go.server.messaging.plugin.PluginNotificationService.notifyPlugins(PluginNotificationService.java:53)
        at com.thoughtworks.go.server.messaging.plugin.PluginNotificationListener.onMessage(PluginNotificationListener.java:30)
        at com.thoughtworks.go.server.messaging.plugin.PluginNotificationListener.onMessage(PluginNotificationListener.java:21)
        at com.thoughtworks.go.server.messaging.activemq.JMSMessageListenerAdapter.runImpl(JMSMessageListenerAdapter.java:65)
        at com.thoughtworks.go.server.messaging.activemq.JMSMessageListenerAdapter.run(JMSMessageListenerAdapter.java:50)
        at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.RuntimeException: Unsuccessful response from plugin. Plugin returned with code '500' and the following response: '{"status":"failure","messages":[null]}'
        at com.thoughtworks.go.plugin.access.PluginRequestHelper.submitRequest(PluginRequestHelper.java:36)
        ... 8 more

Could you have a look?

Thanks! Eugene.

matt-richardson commented 8 years ago

Hi @eugeneventer. I've just released 0.4.0, based on @uprial's change in #2. I believe it was the same issue - let me know how it goes!

euven commented 8 years ago

Hi Matt,

Thanks for looking into this one ;)

I replaced the 0.3 version with 0.4, restarted go-server, but now I cannot even connect to the websocket port. Unfortunately, I cannot see anything in the logs this time... Would you be able to investigate?

Cheers, Eugene.

matt-richardson commented 8 years ago

Hi Eugene

Apologies for that – I tried to do it in a hurry, and its come back and bitten me.

So, I’ve recompiled the jar on ubuntu this time (rather than OS X) and re-uploaded version 0.4. (Probably should’ve upped the version, oh well.)

I gave it a test locally, using http://jsfiddle.net/EAVvQ/24/ pointing at ws://localhost:8887 and it seems happy.

Hopefully this all works for you this time!

Let me know if you do anything cool with it – would be nice to know that people are getting value out of it!

Cheers, matt

From: GitHub notifications@github.com<mailto:notifications@github.com> Reply-To: matt-richardson/gocd-websocket-notifier reply@reply.github.com<mailto:reply@reply.github.com> Date: Sunday, 29 November 2015 at 22:14 To: matt-richardson/gocd-websocket-notifier gocd-websocket-notifier@noreply.github.com<mailto:gocd-websocket-notifier@noreply.github.com> Cc: Matt Richardson Matt@redgumtech.com.au<mailto:Matt@redgumtech.com.au> Subject: Re: [gocd-websocket-notifier] Exception (#1)

Hi Matt,

Thanks for looking into this one ;)

I replaced the 0.3 version with 0.4, restarted go-server, but now I cannot even connect to the websocket port. Unfortunately, I cannot see anything in the logs this time... Would you be able to investigate?

Cheers, Eugene.

— Reply to this email directly or view it on GitHubhttps://github.com/matt-richardson/gocd-websocket-notifier/issues/1#issuecomment-160475827.

euven commented 8 years ago

Thanks for the help Matt - it works now :)

I'm writing a jabber bot that listens for messages from your plugin, then posts to a room. I know I should probably write a GoCD plugin too, but I'm not a Java dev either, so it was just easier to use your plugin ;)

euven commented 8 years ago

https://github.com/eugeneventer/gobot <- my bot that uses your plugin :)

matt-richardson commented 8 years ago

Nice. Looks useful.

Thanks for sharing!