matt-richardson / gocd-websocket-notifier

GoCD plugin to publish build notifications via websockets to any listener
11 stars 7 forks source link

changed port, changed to https, override host verifier #10

Closed chen01 closed 8 years ago

chen01 commented 8 years ago

@matt-richardson

The override is to resolve ssl cert issue with using localhost

matt-richardson commented 8 years ago

Doesn't GoCD launch HTTPS on 8154?

chen01 commented 8 years ago

By default yes, but it appears that we've implemented ours to a different port, so I've just set it to that temporarily in the code to try it out. It resolved my "Connection Refused" issue

matt-richardson commented 8 years ago

Interestingly, it gets a different error on travis: https://travis-ci.org/matt-richardson/gocd-websocket-notifier/builds/160024956#L2705

matt-richardson commented 8 years ago

Ahh - that'd be because its passing in the HTTP port in from the test, but expecting it to be a HTTPS port inside here.

chen01 commented 8 years ago

Actually let me redo this with the HTTP port and try it out