search

matt-richardson / gocd-websocket-notifier

GoCD plugin to publish build notifications via websockets to any listener
11 stars 7 forks source link

add basic auth and go http port #11

Closed chen01 closed 8 years ago

chen01 commented 8 years ago

plugin config can detect go credentials and go http port PipelineDetailPopulator can use basic auth and custom go port if it detects user/pass and/or goHttpPort in conf

@matt-richardson let me know what you think? not certain that the best place to put the new configs is in the PluginConfig class

chen01 commented 8 years ago

Note: Had to add a commons-codec-1.10.jar to library of jar for the base64 encoding of basic auth to work

matt-richardson commented 8 years ago

You'll need to add commons-codec to the pom.xml:

<!-- https://mvnrepository.com/artifact/commons-codec/commons-codec -->
<dependency>
    <groupId>commons-codec</groupId>
    <artifactId>commons-codec</artifactId>
    <version>1.10</version>
</dependency>

This should make the build pass.

chen01 commented 8 years ago

added! 👍

chen01 commented 8 years ago

Let me update the tests

chen01 commented 8 years ago

@matt-richardson I'm not too certain why the connection in downloading pipeline details is being refused in the CI tests. It is working locally for me

matt-richardson commented 8 years ago

Merged and released as 0.4.2+build.60. Thanks!