search

matt-richardson / gocd-websocket-notifier

GoCD plugin to publish build notifications via websockets to any listener
11 stars 7 forks source link

Added option to define/restrict host instead of using wildcard #3

Closed chen01 closed 8 years ago

chen01 commented 8 years ago

Looking to be able to restrict host

Out of curiosity, what superclass are the methods in GoNotificationPlugin overriding? I had to remove the overrides to test it because it couldn't detect a superclass

chen01 commented 8 years ago

@matt-richardson let me know what you think!

Thanks!

matt-richardson commented 8 years ago

LGTM. Thanks!

matt-richardson commented 8 years ago

Of course, as soon as I hit merge, I remember that I was going to ask if you could add something to the readme.md about the new host option.

matt-richardson commented 8 years ago

Released - https://github.com/matt-richardson/gocd-websocket-notifier/releases/tag/0.4.1%2Bbuild.10.

To be honest, I don't know what the GoNotificationPlugin overrides where there for (it was a long time ago). I suspect they were in the plugin that I based this on (https://github.com/ashwanthkumar/gocd-slack-build-notifier). I probably should remove them.

chen01 commented 8 years ago

As far as I can tell it works without the overrides, but if it hasn't caused an issue so far for you than it should be ok!

Thanks for reviewing this!