search

matt-richardson / gocd-websocket-notifier

GoCD plugin to publish build notifications via websockets to any listener
11 stars 7 forks source link

remove override and add defaultGoPluginApiResponse to better handle errors #5

Closed chen01 closed 8 years ago

chen01 commented 8 years ago

No override is needed when implementing methods of an interface in Java

I've also added DefaultGoPluginApiResponse to handle unknown requests and exceptions

chen01 commented 8 years ago

@matt-richardson let me know what you think! thanks!

matt-richardson commented 8 years ago

Looks good - I'll merge soon.

I've been trying to get some integration tests running with GoCD running in a docker container. All working locally, just not so well on travis-ci. Hopefully I've nearly got it sorted.

matt-richardson commented 8 years ago

I'll continue fighting with the docker stuff later. I've merged and its available at https://github.com/matt-richardson/gocd-websocket-notifier/releases/tag/0.4.2%2Bbuild.28.

Let me know how it goes!