matt-s-clark / godot-gdextension-opencv

GDExtension project for OpenCV
MIT License
11 stars 0 forks source link

Api implementation 0.1 #2

Closed RafaDdS closed 1 month ago

RafaDdS commented 1 month ago

This adds the functionality currently present on https://github.com/RafaDdS/OpenCVGodot.

Implementation of:

matt-s-clark commented 1 month ago

Great work! The only suggestion I have is to implement clang-format in your editor so that the code is consistently formatted.

It looks like your clang-format is working correctly, it's just the rules don't always make the code look very elegant if new lines aren't applied in a good place. I added new lines where I think they improve readability. Some of the changes look better than others, particularly the longer signatures - however the shorter signatures have less of a readability issue.