matt-yml / pk

PK's Public system to track issues and update on work
0 stars 0 forks source link

Gyms not listed by name in web gui #53

Closed matt-yml closed 1 year ago

matt-yml commented 1 year ago

Noticed by @sillycuddlebuddy and @mattfal5747 Gyms are sometimes listed by database ID rather than a human friendly name.

https://discord.com/channels/@me/779548491227463680/1032834158403264622

Image

https://discord.com/channels/@me/780212703989465139/1048010111173537863 Image Image

Image

matt-yml commented 1 year ago

Was unable to duplicate with an everything filter, but can duplicate when selecting a specific gym.

Image

matt-yml commented 1 year ago

Tracking details in pk repository here: https://github.com/mattlesnake/gore/issues/435

matt-yml commented 1 year ago

Temporary work around: alerts.pkradar.com

This displays the individual gym names properly. Will continue to look through the direct map api though.

matt-yml commented 1 year ago

Duplicated the problem by adding a specific gym

Image

But [alerts.pkradar.com] shows it correctly.

Image

Unfortunately I don't think adding a specific gym is possible on [alerts.pkradar.com]

matt-yml commented 1 year ago

Checking with reactmap support: https://discord.com/channels/907337201044582452/968137447936491570/1096176182728335562

matt-yml commented 1 year ago

@turtlesocks with the fix. https://discord.com/channels/907337201044582452/968137447936491570/1096177505674743838

[4:58 PM]Turtle: hmm I think it gets these from Poracle, do you have your scanner db added to the poracle config?

scannerdb not set correctly in poracle. added that config and expanded poracle_user's permissions to access the scannerdb.

works like a champ now.

yay

Image

Image

matt-yml commented 1 year ago

somehow this problem came back with a bad merge less than a month after it was fixed. nobody said anything, but just noticed it when trying to add tracking to a single gym in the reactmap alerts interface.

commit 58048c6252ac5855689027b678d954c75b4b4723 (HEAD -> develop) Author: mattle matt.ym.lee@gmail.com Date: Sat Oct 21 12:04:29 2023 -0400

poracle - fix gym name problem that came back.
* gyms are identified by their db id, not human name
* seems like a bad merge in https://github.com/matt-yml/gore/commit/f17bf0fe904b0d2ba6b5138b8958cf6931c1890e
* added scanner type config back into poracle

https://github.com/matt-yml/pk/issues/53