search

matt002 / GaitPy

MIT License
33 stars 23 forks source link

Dependency conflict #23

Open AKuederle opened 4 years ago

AKuederle commented 4 years ago

The project uses strict version dependencies, which is likely to create conflict when installed together with other Python packages.

The way dependencies are set up currently, is not ideal. From the official documentation:

Whereas install_requires requirements are minimal, requirements files often contain an exhaustive listing of pinned versions for the purpose of achieving repeatable installations of a complete environment.

It would be great if you could update the project to only use minimal requirements (>=) in the setup file and pinned version in the requirements file. This would avoid installation issues in more complex environments.

Matt-pfz commented 4 years ago

Hey @AKuederle, thank you raising this issue. Currently, unpinning most of these dependencies result in unit testing errors. Though you are correct, it is best practice to use minimal requirements and I will be working to implement this in future updates.