search

mattanger / ckb-next

RGB Driver for Linux and OS X
http://forum.corsair.com/v3/showthread.php?t=133929
GNU General Public License v2.0
655 stars 76 forks source link

Correction for volup/voldown LED hex codes #360

Closed aktentasche closed 6 years ago

aktentasche commented 6 years ago

see #359 (K63 swapped multimedia keys (led only))

tatokis commented 6 years ago

I am afraid this is not going to work, as it will break all other keyboards that use those LED addresses for those specific keys.

There is a keymap patching mechanism in the works that will do these changes on the fly for specific models, but it needs some serious clean up.

I don't think this should be merged.

aktentasche commented 6 years ago

Agreed if it indeed breaks other keyboards LEDs.

A workaround could be initializing keymap based on keyboard model like you mentioned.

Maybe I can help with the clean-up?

tatokis commented 6 years ago

@aktentasche sorry for the late response, I pushed the code and completely forgot about it. Closing in favour of #374.

Thanks again, much appreciated.