search

mattb112885 / clusterDbAnalysis

ITEP - Integrated Toolkit for Exploration of microbial Pan-genomes
26 stars 15 forks source link

Change database declarations into SQLite standard types #44

Closed mattb112885 closed 11 years ago

mattb112885 commented 11 years ago

Making these changes will make people like me less confused about what SQLite is doing with the data types in the database and more clear what the limitations really are. They won't (shouldn't) change anything about the database as it is now, just clarifies things in the docs.

SQLite does not enforce varchar lengths (https://www.sqlite.org/faq.html#q9) and implicitly changes them into TEXT, so we should make them all TEXT as well so people (like me) don't think their lengths are really limited. I need to comb through and remove checks for this (there's one in checkInputFormat and some in the SQL code itself) since it's pointless.

SQLite does not have a FLOAT type and implicitly changes them into REALs. We should declare them as such

All integer types are treated the same - as INTEGER - as is the boolean type.

mattb112885 commented 11 years ago

I fixed this issue in my latest commit.