mattb112885 / clusterDbAnalysis

ITEP - Integrated Toolkit for Exploration of microbial Pan-genomes

26 stars 15 forks source link

Updating from ETE2 to ETE3 #80

Open JosephRyanPeterson opened 7 years ago

mattb112885 commented 7 years ago

Joe, can you confirm whether the latest version of ETE3 still shows this problem?

https://github.com/mattb112885/clusterDbAnalysis/issues/70

Best

Matt

JosephRyanPeterson commented 7 years ago

Hi Matt, #70 remains an issue with ETE3. I'm digging into it further.

Joe

JosephRyanPeterson commented 7 years ago

70 should be resolved by my most recent commit to my branch. There appeared to be an off-by-one error when populating the columns of the node face. I checked for correctness only with one example though, so take it with a grain of salt.

JosephRyanPeterson commented 7 years ago

Hi Matt, If you don't have any objections, I will merge this pull request and close #70. Joe

mattb112885 commented 7 years ago

The concern I have with this is that people who have the vm distributed with the code won't be able to update ITEP without breaking it. I need to do some compatibility testing, can you hold off on merging for a bit?

Matt