search

mattbdean / JRAW

The Java Reddit API Wrapper
https://mattbdean.gitbooks.io/jraw
MIT License
356 stars 125 forks source link

Add to Votable fields ups and downs, used to get upvote percentage #278

Closed KirkBushman closed 6 years ago

KirkBushman commented 6 years ago

Added those fields, run tests again

codecov[bot] commented 6 years ago

Codecov Report

Merging #278 into master will decrease coverage by 78.7%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #278       +/-   ##
============================================
- Coverage     79.15%   0.44%   -78.71%     
+ Complexity      707       7      -700     
============================================
  Files           131     131               
  Lines          2461    2461               
  Branches        318     318               
============================================
- Hits           1948      11     -1937     
- Misses          329    2449     +2120     
+ Partials        184       1      -183
Impacted Files Coverage Δ Complexity Δ
...rc/main/kotlin/net/dean/jraw/models/GeneralSort.kt 0% <0%> (-100%) 0% <0%> (-1%)
...in/net/dean/jraw/references/ModerationReference.kt 0% <0%> (-100%) 0% <0%> (-2%)
...et/dean/jraw/models/internal/SubredditElement.java 0% <0%> (-100%) 0% <0%> (-3%)
...n/kotlin/net/dean/jraw/references/WikiReference.kt 0% <0%> (-100%) 0% <0%> (-8%)
...va/net/dean/jraw/models/SubredditSearchResult.java 0% <0%> (-100%) 0% <0%> (-2%)
...c/main/java/net/dean/jraw/models/AccountQuery.java 0% <0%> (-100%) 0% <0%> (-3%)
...rc/main/kotlin/net/dean/jraw/http/BasicAuthData.kt 0% <0%> (-100%) 0% <0%> (-3%)
...in/java/net/dean/jraw/models/KarmaBySubreddit.java 0% <0%> (-100%) 0% <0%> (-2%)
...c/main/kotlin/net/dean/jraw/http/NoopHttpLogger.kt 0% <0%> (-100%) 0% <0%> (-3%)
...main/kotlin/net/dean/jraw/http/NetworkException.kt 0% <0%> (-100%) 0% <0%> (-1%)
... and 114 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d466dfe...ca1f876. Read the comment docs.

KirkBushman commented 6 years ago

I bumped libs version since I was at it, if you don't want to, discard.

mattbdean commented 6 years ago

ups is the current score of the post and downs is always 0. A submission's upvote_ratio property is what you're after here.

KirkBushman commented 6 years ago

You are right, I was looking at outdated documentation, upvote_ratio is available only for single GET requests at submissions, not on a list. This defeats the purpose for me, I'm closing this...