mattbierner / vscode-emojisense

Emoji Autocomplete Plugin For VSCode
https://marketplace.visualstudio.com/items?itemName=bierner.emojisense
MIT License
123 stars 9 forks source link

Contributes keybinding Ctrl+Shift+I which replaces `Format Document` #19

Closed mikeseese closed 5 years ago

mikeseese commented 5 years ago

This extension contributes a quick picker for emoji's using the Ctrl+Shift+Ikeybinding. This keybinding conflicts with the Format Document command.

If you're stumbling across this issue, this is how I've done a work around:

Open the keyboard shortcuts: Ctrl+Shift+P => Preferences: Open Keyboard Shortcuts (JSON)

I then redirect the emoji keybinding to Ctrl+Alt+I instead of Ctrl+Shift+I with the following addition to the JSON array

  ...,
  {
    "key": "ctrl+alt+i",
    "command": "emojisense.quickEmojitext",
    "when": "editorTextFocus"
  },
  {
    "key": "ctrl+shift+i",
    "command": "-emojisense.quickEmojitext",
    "when": "editorTextFocus"
  },
  {
    "key": "ctrl+alt+i",
    "command": "emojisense.quickEmojitextTerminal",
    "when": "terminalFocus"
  },
  {
    "key": "ctrl+shift+i",
    "command": "-emojisense.quickEmojitextTerminal",
    "when": "terminalFocus"
  }
mattbierner commented 5 years ago

I don't see any default keybindings for these. What os are you on? Are you using a keymap extension?

mikeseese commented 5 years ago

Hey @mattbierner, I'm on Linux. There are two Ctrl+Shif+I keyboard shortcuts whose source are Default:

image

I'm not using a keymap extension

mattbierner commented 5 years ago

Sorry, I did not know this keybinding was used on linux. We should come up with a different one for linux users. @seesemichaelj Any suggestions for one?

mikeseese commented 5 years ago

I'm using Ctrl+Alt+I which doesn't conflict with any Linux shortcuts. I would have used Ctrl+Alt+E (E for emoji), but it's an awkward movement.

rickstaa commented 3 years ago

Is this still planned? I don't see a related pull request. For now, I similar to @seesemichaelj I will reassign the shortcut, not too much of a hurdle but having it work out of the box would be great.