Cleanup tasks - Githubissues

mattbishop / sql-jsonpath-js

JS implementation of the SQL/JSONPath dialect, from SQL2016.

MIT License

0 stars 0 forks source link

Cleanup tasks #15

Closed mattbishop closed 2 years ago

mattbishop commented 2 years ago

Renamed 'root' to 'context' as the spec calls the thing '$' refers to as the context item.
Tightened up sqlJsonPath to only allow mode or contextQuery as per the spec.
Remove unused 'operand', 'arithmeticOperator' rules.

JeffML commented 2 years ago

The rule arithmeticOperator returns a SqlJsonPathArithmeticOperator, which is part of interface Operation. Where are SqlJsonPathArithmeticOperators being generated now?

mattbishop commented 2 years ago

The operator / operand / rhs bits have been replaced by WFF:

https://github.com/mattbishop/sql-jsonpath-js/blob/a6851bfce3bf15b45033282500c2e58df7a1cbe3/src/json-path.ts#L70

OperaX has connector, which is typed to SqlJsonPathArithmeticOperator.

mattbishop commented 2 years ago

@JeffML arithmeticOperators() is not necessary because each value of the image is the same as the enum. Also, its valid values are managed by the regex pattern so the method does nothing useful.