unicode-identifiers - Githubissues

mattbishop / sql-jsonpath-js

JS implementation of the SQL/JSONPath dialect, from SQL2016.

MIT License

0 stars 0 forks source link

unicode-identifiers #2

Closed mattbishop closed 2 years ago

mattbishop commented 3 years ago

JS object identifiers can be unicode values, including emoji. We will likely need to revisit identifiers when we work on expressions like my😊["a key in my😊"]
Method names for json-path are all ascii, so created a new Token for MethodName.

mattbishop commented 3 years ago

I wrote a little test and found I misread the docs for regex /u so I'll fix it with a better pattern.

mattbishop commented 3 years ago

Also may not be possible: https://chevrotain.io/docs/guide/resolving_lexer_errors.html#UNICODE_OPTIMIZE

We maybe could use the unicode ID_Continue character class, but not use ID_Start because ID_Start is not a single code point that can be used in the workaround.

mattbishop commented 2 years ago

Fixed in https://github.com/mattbishop/sql-jsonpath-js/pull/20